Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename run_specs*.conf to run_entries*.conf #2430

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

yifanmai
Copy link
Collaborator

@yifanmai yifanmai commented Mar 4, 2024

Doing this to disambiguate RunEntry from RunSpec everywhere. See #2404 for more rationale.

Copy link
Contributor

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if anything is motivating this renaming? If we are moving to helm2, are we still keeping this way of doing runs?

@yifanmai yifanmai requested a review from teetone March 5, 2024 18:28
@yifanmai
Copy link
Collaborator Author

I'm trying to stabilize the external CLI interface so that I can finally write the "how to run HELM Lite / HEIM" tutorial.

@yifanmai yifanmai force-pushed the yifanmai/fix-specs-to-entries branch from 2033cf3 to edffbe9 Compare April 3, 2024 01:21
@yifanmai yifanmai merged commit e90a0bd into main Apr 3, 2024
6 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-specs-to-entries branch April 3, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants